Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Menu component tests #13302

Merged
merged 6 commits into from
Feb 25, 2021
Merged

test: Menu component tests #13302

merged 6 commits into from
Feb 25, 2021

Conversation

geido
Copy link
Member

@geido geido commented Feb 23, 2021

SUMMARY

Adds test cases for the Menu component while moving to react-testing-library

@yardz yardz mentioned this pull request Feb 23, 2021
Merged
6 tasks
@junlincc junlincc requested a review from nytai February 23, 2021 21:21
@geido geido marked this pull request as draft February 24, 2021 16:20
@geido geido marked this pull request as ready for review February 24, 2021 17:42
@codecov-io
Copy link

codecov-io commented Feb 24, 2021 •
edited
Loading

Codecov Report

Merging #13302 (68c6bd0) into master (29d6420) will decrease coverage by 18.67%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #13302       +/-   ##
===========================================
- Coverage   77.20%   58.53%   -18.68%     
===========================================
  Files         872      480      -392     
  Lines       45101    16003    -29098     
  Branches     5435     4130     -1305     
===========================================
- Hits        34820     9367    -25453     
+ Misses      10158     6636     -3522     
+ Partials      123        0      -123
Flag Coverage Δ
cypress 58.53% <100.00%> (-0.01%) ⬇️
javascript ?
python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...et-frontend/src/components/Menu/LanguagePicker.tsx 0.00% <ø> (-64.29%) ⬇️
superset-frontend/src/components/Menu/SubMenu.tsx 93.54% <ø> (-6.46%) ⬇️
superset-frontend/src/components/Menu/NewMenu.tsx 70.00% <100.00%> (-8.58%) ⬇️
...uperset-frontend/src/dashboard/util/dnd-reorder.js 0.00% <0.00%> (-100.00%) ⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js 0.00% <0.00%> (-100.00%) ⬇️
...dashboard/components/resizable/ResizableHandle.jsx 0.00% <0.00%> (-100.00%) ⬇️
...tersConfigModal/Footer/CancelConfirmationAlert.tsx 0.00% <0.00%> (-100.00%) ⬇️
...ConfigModal/FiltersConfigForm/FilterScope/state.ts 0.00% <0.00%> (-100.00%) ⬇️
...odal/FiltersConfigForm/FilterScope/ScopingTree.tsx 6.25% <0.00%> (-93.75%) ⬇️
.../src/dashboard/util/getFilterScopeFromNodesTree.js 0.00% <0.00%> (-93.48%) ⬇️
... and 738 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29d6420...68c6bd0. Read the comment docs.

pkdotson
pkdotson approved these changes Feb 25, 2021
View reviewed changes
Copy link
Member

@pkdotson pkdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

rusackas
rusackas approved these changes Feb 25, 2021
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit f3f37b0 into apache:master Feb 25, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@geido
test: Menu component tests (apache#13302)
7819383 
* Add tests for the Menu component

* Clean up and add  NewMenu - SubMenu tests

* Remove obsolete SubMenu test

* Add LanguagePicker tests
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

@pkdotson pkdotson pkdotson approved these changes

@nytai nytai Awaiting requested review from nytai

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XL test:component 🚢 1.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@geido @codecov-io @rusackas @pkdotson @mistercrunch @junlincc